From a44c057992505a03fba3704fe52e6c18e75f94fe Mon Sep 17 00:00:00 2001 From: evrard Date: Thu, 24 Apr 2014 17:05:48 +0200 Subject: [PATCH] Fix a bug on opened status Opened status should be set to false AFTER the close effect has been apply. By this way, the overlay is not considered as opened while closing. --- src/overlay/overlay.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/overlay/overlay.js b/src/overlay/overlay.js index a6cf9ae..971f043 100644 --- a/src/overlay/overlay.js +++ b/src/overlay/overlay.js @@ -192,14 +192,14 @@ e = e || $.Event(); e.type = "onBeforeClose"; fire.trigger(e); - if (e.isDefaultPrevented()) { return; } - - opened = false; + if (e.isDefaultPrevented()) { return; } // close effect effects[conf.effect][1].call(self, function() { e.type = "onClose"; - fire.trigger(e); + fire.trigger(e); + // consider as closed AFTER effect + opened = false; }); // unbind the keyboard / clicking actions