chore: remove redundant word in comment #5662
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed |
mgol
requested changes
May 18, 2025
There was a problem hiding this comment.
Thanks for the PR! I'd like to avoid too many single-line comment fixes so that the commit history doesn't get flooded by them, so I'd like a few other things in this PR before landing:
- Eliminate mentions of Karma - there's another one in "Redefine
blurto avoid a hard crash in Karma tests that stop" where I'd just replace "Karma tests" with "unit tests". - In
test/unit/core.js, replace"root granchild"with"root grandchild". - There are a few occurrences of "with with" to collapse into 1.
I'd be happy to approve this PR with the changes above (and the one from the inline comment I added).
Signed-off-by: studystill <chenghuiyue@outlook.com>
mgol
requested changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove redundant word in comment
Checklist