Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ironhack-labs/lab-javascript-functions-and-arrays
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
Loading
...
head repository: jourisque/lab-javascript-functions-and-arrays
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 3 files changed
  • 3 contributors

Commits on Jan 6, 2018

  1. The description of the test says: "returns the length of the longest … 

    …one" but the test is expecting for the string itself, i change the Readme file wich is the quck fix, but may be could be good to change the spec file to not confuse the student.
    @HectorBlisS
    HectorBlisS committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    06735af View commit details
    Browse the repository at this point in the history

  2. the test are waiting for undefined but the description says false

    @HectorBlisS
    HectorBlisS committed Jan 6, 2018
    Configuration menu
    Copy the full SHA
    7450c21 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2018

  1. Merge pull request #195 from HectorBlisS/counting-repetition-fix 

    the test are waiting for undefined but the description says false
    @papuarza
    papuarza authored Jan 7, 2018
    Configuration menu
    Copy the full SHA
    15495ac View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Merge pull request #194 from HectorBlisS/find-longest-word-fix 

    find-longest-word-little-fix
    @papuarza
    papuarza authored Jan 8, 2018
    Configuration menu
    Copy the full SHA
    c4f4d5a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. done

    @jourisque
    jourisque committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    e07c803 View commit details
    Browse the repository at this point in the history
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.