Fix: use UTF-8 safe substr in mod_articles_category #46250
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard67
reviewed
Oct 8, 2025
| switch ($type) { | ||
| case 'month_year': | ||
| $month_year = StringHelper::substr($item->$field, 0, 7); | ||
| $month_year = StringHelper::substr($item->$field, 0, 7,'UTF-8'); |
There was a problem hiding this comment.
Suggested change
| $month_year = StringHelper::substr($item->$field, 0, 7,'UTF-8'); | |
| $month_year = StringHelper::substr($item->$field, 0, 7, 'UTF-8'); |
Code style
richard67
reviewed
Oct 8, 2025
|
|
||
| default: | ||
| $year = StringHelper::substr($item->$field, 0, 4); | ||
| $year = StringHelper::substr($item->$field, 0, 4,'UTF-8'); |
There was a problem hiding this comment.
Suggested change
| $year = StringHelper::substr($item->$field, 0, 4,'UTF-8'); | |
| $year = StringHelper::substr($item->$field, 0, 4,'UTF-8'); |
Suggested change
| $year = StringHelper::substr($item->$field, 0, 4,'UTF-8'); | |
| $year = StringHelper::substr($item->$field, 0, 4, 'UTF-8'); |
Code style
|
This pull request has been automatically rebased to 5.4-dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: use UTF-8 safe substr for multibyte support in mod_articles_category
Fixes #45452
Summary of Changes
Replaced the regular
substr()function withmb_substr()inmod_articles_categoryto ensure correct multibyte string handling for UTF-8 encoded text.Testing Instructions
Actual result BEFORE applying this Pull Request
Multibyte characters were sometimes cut off or displayed incorrectly.
Expected result AFTER applying this Pull Request
Multibyte characters are displayed correctly and not truncated.
Link to documentations