Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Typecast some variables to string to eliminate the deprecation warnings on PHP 8.5

Testing Instructions

open /administrator/index.php?option=com_menus&view=menus (PHP8.5 required and error reporting to max)

Actual result BEFORE applying this Pull Request

Deprecations logged

Deprecated: Using null as an array offset is deprecated, use an empty string instead in /administrator/components/com_menus/src/Model/MenuModel.php on line 369

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67

@dgrammatiko dgrammatiko changed the title PHP8.5 Deprecations [5.4] PHP8.5 Deprecations Sep 20, 2025
administrator/components/com_menus/src/Model/MenuModel.php Outdated Show resolved Hide resolved
Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 14d92f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7834db2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 29, 2025
@heelc29
Copy link
Contributor

heelc29 commented Oct 1, 2025

I have tested this item ✅ successfully on 7834db2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136.

@HLeithner HLeithner added the bug label Oct 4, 2025
@richard67 richard67 modified the milestones: 5.4.1, Joomla! 5.4.1 Oct 7, 2025
@muhme
Copy link
Contributor

muhme commented Oct 15, 2025

Final test before merge using JBT php8.5-rc

  • Seen Deprecated messages on three line numbers before PR on
    'administrator/index.php?option=com_menus&view=menus'
  • graft PR's full packge
    • ✅ no Deprecated anymore, opening menu entry, creating and deleting menu entry is still working

@muhme muhme merged commit 156bd61 into joomla:5.4-dev Oct 15, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 15, 2025
@muhme
Copy link
Contributor

muhme commented Oct 15, 2025

Thank you @dgrammatiko for your contribution. Thank you @joomdonation and @richard67 for supporting. Thank you @brianteeman, @heelc29 and @joomdonation for testing.

@dgrammatiko dgrammatiko deleted the patch-4 branch October 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.