-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[5.4] PHP8.5 Deprecations #46136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[5.4] PHP8.5 Deprecations #46136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tuan Pham Ngoc <github@joomdonation.com>
Contributor
|
I have tested this item ✅ successfully on 14d92f4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136. |
richard67
approved these changes
Sep 22, 2025
Contributor
|
I have tested this item ✅ successfully on 7834db2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136. |
Contributor
|
I have tested this item ✅ successfully on 7834db2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46136. |
Contributor
|
Final test before merge using JBT php8.5-rc
|
Contributor
|
Thank you @dgrammatiko for your contribution. Thank you @joomdonation and @richard67 for supporting. Thank you @brianteeman, @heelc29 and @joomdonation for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Typecast some variables to string to eliminate the deprecation warnings on PHP 8.5
Testing Instructions
open
/administrator/index.php?option=com_menus&view=menus(PHP8.5 required and error reporting to max)Actual result BEFORE applying this Pull Request
Deprecations logged
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@richard67