Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Bugfixes #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 54 commits into
base: dev-deprecated-please-target-master-directly
Choose a base branch
Loading
from
Open

Bugfixes #953

wants to merge 54 commits into from

Conversation

Felioh
Copy link
Contributor

@Felioh Felioh commented May 16, 2024

This fixes some inconsistencies with the XRay API:

I suspect the source of these bugs is somewhere else since the documentation (and this client?) is generated?

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

omerzi and others added 30 commits April 5, 2023 09:49
@omerzi
Promote version to 1.28.1 (jfrog#733)
a664ea4
@eyalbe4
Added the Frogbot badge to the README (jfrog#740)
0b22cb3
@sverdlov93
Merge remote-tracking branch 'upstream/dev' into masterupstream
93d1ee0 
# Conflicts:
#	.github/workflows/analysis.yml
#	go.mod
#	go.sum
#	utils/utils.go
#	xray/services/scan.go
#	xray/services/scan_test.go
@omerzi
Merge remote-tracking branch 'origin/dev'
60012f0
@eyalbe4
Merge branch 'dev'
72340a7
@talarian1
Merge remote-tracking branch 'origin/dev'
3c0e410
@omerzi
Merge remote-tracking branch 'origin/dev'
7dd161b
@talarian1
Merge remote-tracking branch 'origin/dev'
88f4c5c
@yahavi
Merge branch 'master' into dev
21b99ad
@yahavi
Promoted version to 1.29.1
b71c280
@eyalbe4
Merge branch 'dev'
8f7755c
@eyalbe4
Merge branch 'dev'
e6ba583
@RobiNino
Merge branch 'dev'
b624428
@omerzi
Merge branch 'master' into dev
da0c018
@omerzi
Promoted version to 1.31.1
f750025
@omerzi
Merge remote-tracking branch 'origin/dev'
e1d57bd 
# Conflicts:
#	utils/utils.go
@eyalbe4
Merge branch 'dev'
886ff5f
@eyalbe4
Promoted version to 1.31.3
b1ae836
@eyalbe4
Merge branch 'dev'
df38e23
@eyalbe4
Merge branch 'dev'
46b7fb9
@eyalbe4
Resolve conflicts
5f58723
@eyalbe4
Merge branch 'dev'
080ef1a
@attiasas
Merge branch 'dev'
7c244c5
@EyalDelarea
Merge branch 'master' into dev
6d1c9e7
@EyalDelarea
Merge remote-tracking branch 'origin/dev'
b3d917f
@sverdlov93
Merge remote-tracking branch 'upstream/dev'
3be412b
@RobiNino
Merge branch 'dev'
fa697b5
@eranturgeman
Merge remote-tracking branch 'origin/dev'
7b2943f
@eranturgeman
Merge remote-tracking branch 'jfrog-prod/dev'
15552e7
@yahavi
Merge remote-tracking branch 'origin/dev'
9684938
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Felioh
Copy link
Contributor Author

Felioh commented May 16, 2024

I have read the CLA Document and I hereby sign the CLA

@attiasas attiasas self-requested a review August 13, 2024 06:21
attiasas
attiasas requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the WatchRecipients is fine, I don't think the other change is needed.

xray/services/report.go Show resolved Hide resolved
@Felioh
Copy link
Contributor Author

Felioh commented Aug 13, 2024

don't think the other change is needed

What other change?

@attiasas
Copy link
Contributor

don't think the other change is needed

What other change?

The Due Diligance (License) report contains the license key in a json-field named 'license_key' not 'license'. https://jfrog.com/help/r/xray-rest-apis/get-due-diligence-report-content (Also incorrect in the documentation)

so the right attribute is license_key no need to change

@Felioh Felioh requested a review from attiasas September 2, 2024 08:32
@Felioh
Copy link
Contributor Author

Felioh commented Nov 13, 2024

Is there a reason, why this hasn't been merged?

@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 20, 2025
@ehl-jf ehl-jf added the stale label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas Awaiting requested review from attiasas

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.