Feature/rteco 456 implement groups api amnd versions ap is #1246
+419
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
agrasth
reviewed
Oct 13, 2025
agrasth
reviewed
Oct 13, 2025
bhanurp
reviewed
Oct 14, 2025
lifecycle/services/rbSearch.go
Outdated
| } | ||
| return response, sendErr | ||
| } | ||
| log.Debug("Artifactory response status:", resp.Status) |
There was a problem hiding this comment.
is this required? from the error returned it should be obvious.
There was a problem hiding this comment.
Actually all the existing APIs are having this response output line.
bhanurp
requested changes
Oct 14, 2025
lifecycle/lifecycle_test.go
Outdated
| } | ||
|
|
||
| func TestReleaseBundlesSearchGroups(t *testing.T) { | ||
| mockServer, rbService := createMockServer(t, func(w http.ResponseWriter, r *http.Request) { |
There was a problem hiding this comment.
suggestion: check if using this package helps instead of creating mock server
https://pkg.go.dev/net/http/httptest
There was a problem hiding this comment.
I am using only existing style for testing. createMockServer function is used by all unit tests.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Added logic for handling input and structure.