Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

reshmifrog
Copy link
Contributor

@reshmifrog reshmifrog commented Sep 17, 2025

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the master branch.
  • I used gofmt for formatting the code before submitting the pull request.

Problem: We were experiencing an issue where artifacts are not being resolved according to the defined resolution order in a virtual repository when using the JFrog CLI.

Solution: Added support for direct download command to download artifacts bypassing the aql

@reshmifrog reshmifrog added the improvement Automatically generated release notes label Sep 17, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 22, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2025
artifactory/manager.go Show resolved Hide resolved
artifactory/services/directdownload.go Show resolved Hide resolved
artifactory/services/directdownload.go Show resolved Hide resolved
artifactory/services/directdownload.go Show resolved Hide resolved
artifactory/services/directdownload.go Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownloadparams.go Show resolved Hide resolved
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Sep 25, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 25, 2025
artifactory/manager.go Show resolved Hide resolved
downloadCount := 0
failCount := 0

for _, child := range storageInfo.Children {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a for loop downloading files being matched by the wildcard pattern, by any chance is it possible to download all the children files parallely, i.e. using goroutines?

artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownloadparams.go Show resolved Hide resolved
artifactory/services/directdownloadparams.go Show resolved Hide resolved
artifactory/services/directdownloadparams.go Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
artifactory/services/directdownload.go Show resolved Hide resolved
artifactory/services/directdownload.go Outdated Show resolved Hide resolved
@ehl-jf ehl-jf added the safe to test Approve running integration tests on a pull request label Oct 8, 2025
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 8, 2025
Copy link
Contributor

github-actions bot commented Oct 8, 2025

👍 Frogbot scanned this pull request and did not find any new security issues.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.