Updated the escaping function for URL encoding #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhanurp
requested changes
Sep 15, 2025
bhanurp
approved these changes
Sep 15, 2025
…e-Due-to-String-Encoding
…e-Due-to-String-Encoding
…to-String-Encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Due to this https://github.com/jfrog/jfrog-client-go/pull/1130/files,
Build Promotion Failure Due to String Encoding as BuildUrlWithEscapingSlash.
Solution
Replace QueryEscape function to PathEscape, because QueryEscape does double encoding and when / present inside build name and number, due to which wrong URL are generating. So, we need to encode special characters only except /.
Changes required as part https://github.com/jfrog/jfrog-client-go/pull/1130/files, are not affected with this PR's changes.
Attaching screenshots for reference.