Adding column index and line matching attributes (line_index, and line_pattern) to csv2 column decl and json validation schema #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_pattern) to csv2 column decl and json validation schema Turns out if we want to support multi-line record (whether it's fixed number of rows based or header/footer based) in csv we will have to let each column to specify which line the column value should come from, and of that particular line, which indexed value to use, thus the adding of `index`, `line_index` and `line_pattern`.
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 51
Lines 2802 2836 +34
=========================================
+ Hits 2802 2836 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out if we want to support multi-line record (whether it's fixed number of rows based or header/footer based) in csv we will have to let each column to specify which line the column value should come from, and of that particular line, which indexed value to use, thus the adding of
index,line_indexandline_pattern.