Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Examples / Standardize folder names #5626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 21, 2018

Conversation

neosiae
Copy link
Contributor

@neosiae neosiae commented Feb 20, 2018

Summary

Part of #4969

This PR renames folder names in the examples folder.

- Folder names should use dashes, unless they are special folders.

Test plan

All the test cases pass.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #5626 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5626      +/-   ##
=========================================
- Coverage   60.93%   60.9%   -0.04%     
=========================================
  Files         215     215              
  Lines        7334    7325       -9     
  Branches        4       4              
=========================================
- Hits         4469    4461       -8     
+ Misses       2864    2863       -1     
  Partials        1       1
Impacted Files Coverage Δ
...st-cli/src/plugins/update_snapshots_interactive.js 37.5% <0%> (-6.95%) ⬇️
packages/jest-cli/src/watch.js 72.46% <0%> (-0.27%) ⬇️
packages/jest-cli/src/plugins/test_name_pattern.js 100% <0%> (ø) ⬆️
packages/jest-cli/src/plugins/test_path_pattern.js 100% <0%> (ø) ⬆️
packages/jest-cli/src/plugins/update_snapshots.js 100% <0%> (ø) ⬆️
packages/jest-cli/src/base_watch_plugin.js
packages/jest-cli/src/watch_plugin.js 50% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79533a9...aa86f4c. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@cpojer cpojer merged commit 7bcdc8c into jestjs:master Feb 21, 2018
@cpojer
Copy link
Member

cpojer commented Feb 21, 2018

Thank you!

@neosiae neosiae changed the title Examples/standardize folder names Examples / Standardize folder names Feb 21, 2018
@neosiae neosiae deleted the examples/standardize-folder-names branch February 21, 2018 16:21
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.