make cleanup and pre-creation recurrence period configurable #352
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be pretty useful. Even if the jobs aren't short, when the build queue gets longer it's painful to wait 10 minutes for a VM to get removed. |
|
Hello, Will this pull request be merged in the next releases? Have a great day. |
Contributor
|
Hi, is there any reason why this PR is not merged ? |
Contributor
|
Partially done with #393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows Jenkins operator to configure the recurrence period for cleanup and pre-creation threads.
This allows to faster cleanup and pre-creating machines, I find this setting particular useful in scenario where openstack agents are single-use (1 executor, 0 retention time) and combined with set of quick jobs (less than 1 minute or so) that are often executed. It may lead to situation when openstack plugin is not able to create new machines due to hitting limit but at the same time the already existing machines are marked for termination filling up quota. In worst case almost 10 min to get cleanup and freed up limit.
Implementation has been inspired by same issue in ec2 jenkins plugin
This PR relates to #282