[JENKINS-75704] Fix Copilot user null name/email handling #864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate tests - Updated logic so that only the copilot user is allowed to bypass missing name and email checks in pull request processing. - All other users without name/email are marked as unknown and a log message is generated. - Added and updated tests to verify that copilot is accepted and handled as expected.
I see no evidence of such a change in the current patch; did you revert it? If so, please update the PR description accordingly. |
jglick
reviewed
Jun 20, 2025
| @@ -2572,17 +2572,22 @@ public void observe(GHPullRequest pr) { | ||
| GHUser user = null; | ||
| try { | ||
| user = pr.getUser(); | ||
| if (users.containsKey(user.getLogin())) { | ||
| // looked up this user already |
There was a problem hiding this comment.
may as well retain this comment in the else clause
jglick
reviewed
Jun 20, 2025
| ContributorMetadataAction contributor = | ||
| new ContributorMetadataAction(user.getLogin(), user.getName(), user.getEmail()); | ||
| pullRequestContributorCache.put(number, contributor); | ||
| // store the populated user record now that we have it |
jglick
reviewed
Jun 20, 2025
| } catch (FileNotFoundException e) { | ||
| // If file not found for user, warn but keep going |
jglick
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the handling of pull requests and commits authored by GitHub IA, Copilot, who may not have a real GitHub account or may lack a defined name or email.
It prevents exceptions and ensures that these contributions are not discarded during indexing or processing.
Changes
Special handling for the "copilot" user:
"copilot", a syntheticContributorMetadataActionis created with:"copilot""copilot@unknown.user"Other users:
login,name, andemail) with no fallback.If
user.getName()oruser.getEmail()arenull, those fields will remainnullas before.Unchanged logic for missing users:
Motivation
GitHub Copilot and other bots can appear as authors of commits and pull requests, but may not exist as real users in GitHub.
Without this special handling, such PRs would be discarded or cause exceptions, impacting the visibility and traceability of AI-generated or bot-generated contributions.
See JENKINS-75704 for further information.
Submitter checklist
No automated tests were added because this is a trivial change: it only handles null values or exceptions when fetching the GitHub user's name/email for logging purposes, defaulting to safe values if missing. It does not affect business logic or the core functionality of the plugin.
Reviewer checklist
Documentation changes
Users/aliases to notify