Make some helper methods protected in DefaultPrettyPrinterVisitor #4729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4729 +/- ##
===========================================
Coverage 58.303% 58.303%
Complexity 2512 2512
===========================================
Files 671 671
Lines 38761 38761
Branches 7031 7031
===========================================
Hits 22599 22599
Misses 13270 13270
Partials 2892 2892
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This makes it much easier to override visitor methods
6b838d2 to
d6958b0
Compare
|
I have no objection to integrate these changes, even if the methods concerned are not intended to be overloaded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been spun off from the closed #4717.
Making these helper methods protected makes it much easier to override visitor methods in customer pretty-printer visitors.