Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Jan 25, 2019. It is now read-only.

Conversation

@vinayvishal
Copy link
Contributor

1st example demonstrates built-in DatabaseIdentityStore usage as specified in JSR 375. Details can be found in the README of this example.

2nd example demonstrates CustomIdentityStore usage as specified in JSR 375. Details can be found in the README of this example.

@vinayvishal
Copy link
Contributor Author

@wmhopkins @bbuerkle , replaced the #1 with this #3. Review comments have already been incorporated in this request.

@bshannon
Copy link
Member

bshannon commented Jun 5, 2018

This pull request has been sitting here for a long time. Can we get the reviewers to review it,
or the submitter to cancel it?

@wmhopkins
Copy link
Member

Looks reasonable to me. I'm OK submitting it if it's still appropriate. (Don't know whether another PR providing equivalent or alternative content was ever submitted.)

@vinayvishal -- If this is still appropriate to submit, please go ahead.

@bbuerkle
Copy link

Hi Vinay - I just downloaded EE8 and I do not see the CustomIdentityStore example. I documented it, and based on earlier email from you, it was supposed to be available at tut-install/examples/security/security-api, which is what I documented. I received another comment from a user indicating that they could not find the example. Is there any plan to publish it?

@bbuerkle
Copy link

@vinayvishal @wmhopkins
Hi Vinay - I just downloaded EE8 and I do not see the CustomIdentityStore example. I documented it, and based on earlier email from you, it was supposed to be available at tut-install/examples/security/security-api, which is what I documented. I received another comment from a user indicating that they could not find the example. Is there any plan to publish it?

Also - the built-in-db-identity-store example is located at glassfish5/samples/security/jsr375 and not tut-install/examples/security/security-api/built-in-db-identity-store as expected and documented.

@vinayvishal vinayvishal merged commit f86b428 into javaee:master Jun 14, 2018
@vinayvishal
Copy link
Contributor Author

Hi Barbara, I have merged it now.. 8.0 tutorial examples got released and integrated with SDK (20-Sep) before this PR was created (22-Sep) and hence it got missed out being added in release cycle and I guess that's why it was still open.

@bbuerkle
Copy link

Hi Vinay - two questions.

  1. Are there plans to re-release the SDK that would include this example?
  2. Where will the example be located? tut-install/examples/security/security-api, which is what I documented, or glassfish5/samples/security/jsr375, which is where the built-in-db-identity-store example is located?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.