Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Added animation type for RN Modal #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
Loading
from
Open

Added animation type for RN Modal #145

wants to merge 6 commits into from

Conversation

JNelder
Copy link

@JNelder JNelder commented Mar 31, 2022

No description provided.

@RyanPliske
Copy link

RyanPliske commented Sep 12, 2023 •
edited
Loading

for those of you looking for a way around this. I was able to get this to work:

class CustomModal extends Modal {
  render(): React.ReactNode {
    // eslint-disable-next-line react/jsx-props-no-spreading
    return <Modal {...this.props} animationType="fade" />
  }
}

<Tooltip
   modalComponent={CustomModal}
>

jasongaare
jasongaare reviewed Sep 12, 2023
View reviewed changes
Copy link
Owner

@jasongaare jasongaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough, let's change the defaultProp and we are good to go

src/tooltip.js
useReactNativeModal: true,
topAdjustment: 0,
accessible: true,
animationType: 'fade',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the current default is 'none' could you update this so it is backward compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasongaare jasongaare jasongaare left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JNelder @RyanPliske @jasongaare @jnelder1
Morty Proxy This is a proxified and sanitized view of the page, visit original site.