Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixes 'get' and 'set' keyword example in docs #4990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2018
Merged

Fixes 'get' and 'set' keyword example in docs #4990

merged 1 commit into from
Feb 25, 2018

Conversation

zdenko
Copy link
Collaborator

@zdenko zdenko commented Feb 25, 2018

Fixes error in the example for get and set keyword syntax in docs.

screen =
  width: 1200
  ratio: 16/9

Object.defineProperty screen, 'height',
  get: ->
    this.width / this.ratio
  set: (val) ->
    this.width = val * this.ratio

# this.height = 675

this.height = 900

# this.width = 1600

@GeoffreyBooth
Copy link
Collaborator

Ah. Yes. Thanks 😄

@GeoffreyBooth GeoffreyBooth merged commit 7542a75 into jashkenas:master Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zdenko @GeoffreyBooth
Morty Proxy This is a proxified and sanitized view of the page, visit original site.