Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove Security Manager#1295

Merged
mkarg merged 2 commits into
jakartaee:release-5.0jakartaee/rest:release-5.0from
mkarg:remove-service-managermkarg/rest:remove-service-managerCopy head branch name to clipboard
Jan 3, 2025
Merged

Remove Security Manager#1295
mkarg merged 2 commits into
jakartaee:release-5.0jakartaee/rest:release-5.0from
mkarg:remove-service-managermkarg/rest:remove-service-managerCopy head branch name to clipboard

Conversation

@mkarg
Copy link
Copy Markdown
Contributor

@mkarg mkarg commented Dec 21, 2024

This PR removes the support for Security Manager.

closes #1262

Requesting fast-track according to our Committer Conventions, as this PR is a non-API, non-spec, non-javadoc change.

@mkarg mkarg added this to the 5.0 milestone Dec 21, 2024
@mkarg mkarg self-assigned this Dec 21, 2024
@mkarg mkarg requested a review from jansupol December 22, 2024 09:21
@jansupol jansupol changed the title Remove Service Manager Remove Security Manager Dec 22, 2024
@jansupol
Copy link
Copy Markdown
Contributor

Hm...the commit will be forever titled Remove Service Manager instead of Security Manager in the git history....

@mkarg
Copy link
Copy Markdown
Contributor Author

mkarg commented Dec 22, 2024

Hm...the commit will be forever titled Remove Service Manager instead of Security Manager in the git history....

Good catch, and thank you for changing the typo, but actually it will not show up in git history anyways: The commit itself does not have the typo, and when using "Rebase and merge" in Github, the title of the PR will not show up in the git history. 🙂

@jansupol
Copy link
Copy Markdown
Contributor

You are right, sorry, I have not checked the commit message

Copy link
Copy Markdown
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for 5.0

@mkarg mkarg requested a review from a team December 23, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.