Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix the weights error arising from || #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from

Conversation

noriakis
Copy link

Hello. Thank you for developing this important and fast library for BN inference.
On the latest version of R, the ccdr.run function results in the corresponding error because of ||.

### Generate some random data
dat <- matrix(rnorm(1000), nrow = 20)
dat <- sparsebnUtils::sparsebnData(dat, type = "continuous")
# Run with default settings
ccdr.run(data = dat, lambdas.length = 20)
Error in weights < -1 || weights > 1 : 
  'length = 2500' in coercion to 'logical(1)'

This PR removes the error, and possibly solves itsrainingdata/sparsebn#14.

I would be grateful if you could review the codes for the possible merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.