BCN - Åsa Eriksson #549
Closed
BCN - Åsa Eriksson #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawebbcn
reviewed
Sep 19, 2018
| function maxOfTwoNumbers(num1, num2) { | ||
| if (num1 > num2) { | ||
| return num1; | ||
| } else if (num2 > num1) { |
There was a problem hiding this comment.
En este caso, no es necesario la segunda condición. El primer if compara si es mayor, si no lo es significa que el segundo es menor si o si.
El resultado sería el siguiente:
function maxOfTwoNumbers(num1, num2) {
if (num1 > num2) {
return num1;
} else {
return num2;
}
}
tawebbcn
reviewed
Sep 19, 2018
| var avgSum = sumArray(numbersAvg); | ||
| if (numbersAvg.length < 1) { | ||
| return undefined; | ||
| } else return avgSum / numbersAvg.length; |
There was a problem hiding this comment.
else return avgSum / numbersAvg.length; ->
else {
return avgSum / numbersAvg.length;
}
|
Muy bien Åsa, intenta revisar los dos comentarios que te he dejado sobre el código y por lo demás todo correcto 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.