Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[MAD DE 0123] Gimena Motto #3570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GimenaMotto
Copy link

Me ha llevado un buen rato relajarme, al principio me nublé demasiado. Cuando conseguí estar más tranquila pude empezar a fluir más y sacarlos poco a poco.
en #2 #4 y algún otro ejemplo me gustaría saber si sería necesario agregar else o no....
Gracias!!

Copy link
Contributor

@ta-web-mad ta-web-mad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola Pimba!

Los ejercicios que tienes hecho estan genial, supongo que no te daria tiempo a hacer el resto. No pasa nada, intenta seguir con los nuevos LABs y si ves que te quedas muy estancada en algun punto no dudes en preguntarnos. Si te quedas con la intriga te podria explicate algun ejercicio en especifico, comentame y lo vemos juntas!

Mucho animo!


if (words.length === 0) {
return null
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dado que 0 es un valor falsy, este condicional podría refactorizarse de esta manera (más elegante y común en la industria):

if (!words.length) {
return null
}

Por otra parte, cuando el cuerpo de un condicional solo contiene una expresión, no es necesario servirse de bloques. Podemos refactorizar esa parte así (aplicable a cualquier parte del código):

if (!words.length) return null

Así queda un poco más limpio y organizado.

@stale
Copy link

stale bot commented Apr 3, 2023

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 3, 2023
@stale
Copy link

stale bot commented Apr 7, 2023

This pull request is closed. Thank you.

@stale stale bot closed this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.