Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@michellebro
Copy link

Work by Juan and Michelle

@michellebro
Copy link
Author

Our project

@michellebro michellebro closed this Apr 3, 2017
@michellebro michellebro reopened this Apr 3, 2017
Apple pie coding finished
@matilore matilore closed this Apr 4, 2017
@pbojork pbojork mentioned this pull request Jan 7, 2019
MarySueMe pushed a commit to MarySueMe/lab-javascript-basic-algorithms that referenced this pull request May 12, 2023
Sandra, there was a merge conflict due to the renaming of the test spec file, I resolved it locally.

I like the addition of the bonus iterations. I find both a considerably harder than the rest. I added an extra bit of clarification regarding how values of different types should be added up.

Do you think we should instruct students to not do them in the normal flow of the lab, and only tackle them at the end? Could we ponder moving them to the end of the lab?

Additionally, I split the last iteration and passed the requirement to calculate the products diagonally to an extra iteration, ironhack-labs#8.1, since my current cohort found it significantly more complex to solve than horizontally and diagonally. Specs don't include any tests for the diagonal product.

I'm merging this the PR into master, but I think that it would be productive to follow up on this Lab and do some additional work on it.

Cheers!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.