[ING-FT-112019]-Kai and Tomasz #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log(`The driver has the longest name, it has ${hacker1.length} characters`); | ||
| else if (hacker1.length < hacker2.length) | ||
| console.log(`It seems that the navigator has the longest name, it has ${hacker2.length} characters`); | ||
| else |
There was a problem hiding this comment.
prefer an explicit condition like " === "
| let str = ""; | ||
|
|
||
| for (let i = 0; i < hacker1.length; i++) { | ||
| str = str + hacker1.charAt(i) + " "; |
| let str2 = ""; | ||
|
|
||
| for (let i = hacker2.length - 1; i >= 0; i--) { | ||
| str2 = str2 + hacker2.charAt(i); |
| console.log(`The driver's name goes first`); | ||
| else if (hacker1 > hacker2) | ||
| console.log(`Yo, the navigator goes first definitely.`); | ||
| else |
There was a problem hiding this comment.
prefer explicit condition like " = "
| let text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc nulla risus, volutpat ut consectetur eu, cursus in elit. Fusce accumsan id arcu a lacinia. Nunc faucibus posuere ante, vel fringilla diam malesuada eget. Pellentesque feugiat non ipsum sed bibendum. Pellentesque sed dapibus ipsum, sit amet volutpat ligula. Donec imperdiet id nibh sed condimentum. Vivamus faucibus quis metus quis gravida. Vivamus dictum feugiat ex, ac tempus justo tincidunt sed. Phasellus nisl justo, eleifend vitae pellentesque ut, tristique sit amet augue. Praesent aliquam porttitor lorem, et euismod risus eleifend a. Morbi mattis gravida ante. Proin metus augue, dictum volutpat sagittis sed, vehicula sed tellus. Pellentesque consequat, justo eu consectetur ornare, ex elit fermentum est, sed mattis diam dolor non lacus. Vivamus laoreet viverra faucibus. Praesent volutpat congue lorem et mollis. In hac habitasse platea dictumst. Vestibulum semper vel lectus ut vulputate. Maecenas sagittis, urna sed accumsan dapibus, justo quam aliquam enim, eget congue lorem massa vel metus. Sed ut ligula orci. Aenean quis porttitor neque. Sed eu massa feugiat, aliquet justo a, rutrum ligula. Quisque sed quam sit amet dui iaculis tristique non et orci. Morbi quis vehicula justo. Vivamus sem dui, aliquam laoreet urna at, vulputate consectetur nisi. Morbi laoreet ullamcorper libero, at vulputate nibh scelerisque at. Ut accumsan, nibh vitae tristique efficitur, massa est placerat dolor, nec ornare mi risus et eros. Ut a risus vel leo vestibulum condimentum. Maecenas iaculis magna felis, in interdum odio lacinia eget. Phasellus eget laoreet est. Curabitur tristique pretium odio nec congue. Phasellus faucibus metus non elit sollicitudin pellentesque. Integer id vestibulum justo. Etiam eros ex, sodales vel est vel, mattis blandit risus. Aliquam et nibh volutpat, rutrum magna ut, fringilla nisl. In ultricies, lacus non hendrerit cursus, ante neque congue enim, eget vulputate velit erat eget est. Mauris varius odio vitae blandit sodales." | ||
| let wordcount = 0; | ||
|
|
||
| for (let i = 0; i <= text.length; i++) { |
There was a problem hiding this comment.
ERROR: correct to i < text.length
| console.log(`number of words from text is: ${wordcount}`); | ||
|
|
||
| // Iteration 3: Loops No newline at end of file | ||
| let found = 0; |
There was a problem hiding this comment.
Could be greatly simplified. Please read documentation about indexOf()
|
|
||
| let str = ""; | ||
|
|
||
| for (let i = 0; i < hacker1.length; i++) { |
There was a problem hiding this comment.
prefer use of localeCompare() as per lesson instructions
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.