MIA-FTWD Steven Englander / Alfredo Rojas #430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ta-web-mia
reviewed
Jun 10, 2019
| console.log(`wow, you both got equally long names, ${hacker1.length} characters!!`) | ||
| } | ||
|
|
||
| let hacker1UpperSpaced = hacker1.toUpperCase(); |
There was a problem hiding this comment.
Nice job condensing this step into just two lines! Same goes for the reversed string as well.
ta-web-mia
reviewed
Jun 10, 2019
| @@ -1,7 +1,37 @@ | ||
| // Names and Input | ||
| let hacker1 = "Alfredo"; | ||
| console.log(`The driver's name is ${hacker1}`); |
There was a problem hiding this comment.
Big fan of the newer string concatenation syntax using backticks. Very good habit to get into early!
ta-web-mia
reviewed
Jun 10, 2019
| let lowerCaseString = userString.toLowerCase(); | ||
|
|
||
| /* | ||
| function isPalindrome (lowerCaseString) { |
There was a problem hiding this comment.
With palindromes, make sure you reverse the string first and see what it looks like.
|
Nice work! Keep it up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the Bonus work