-
Notifications
You must be signed in to change notification settings - Fork 5.8k
PP MEX - Felipe Victoria #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| for (i = 0; i < hacker1.length; i++ ){ | ||
| capitalizedName += " "+ hacker1[i].toUpperCase(); | ||
| } | ||
| console.log(capitalizedName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muy bien, pero si notan está sobrando un espacio en el início de la cadena. Pueden removerlo usando los métodos .slice(1) o .trim().
| } | ||
| console.log(capitalizedName); | ||
|
|
||
| for (a = hacker2.length; a >= 0; a--){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Una pequeña corrección: si notan, hay un espacio en el início del reverseName. Eso pasa porque el índice de los caracteres en la cadena empieza en 0, pero el conteo del length empieza en 1. Para empezar en la última letra de la cadena, el valor inicial de i deberia de ser hacker2.length-1
| } | ||
| } | ||
|
|
||
| checkPalindrome(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excelente. Una sugerencia: si convierten storeString y palindromeString a minúsculas antes de checarlas, podrían identificar tambien palíndromos en nombres ("Ana", por ejemplo).
|
Excelente trabajo y felicidades por haber terminado los bonus! |
Terminamos el Pair Programming y todos los bonus, esperamos los stickers!