BCN-WDFT-ESTER-XAVI#336
Closed
eFernP wants to merge 1 commit intoironhack-labs:masterironhack-labs/lab-javascript-basic-algorithms:masterfrom
Closed
BCN-WDFT-ESTER-XAVI#336eFernP wants to merge 1 commit intoironhack-labs:masterironhack-labs/lab-javascript-basic-algorithms:masterfrom
eFernP wants to merge 1 commit intoironhack-labs:masterironhack-labs/lab-javascript-basic-algorithms:masterfrom
Conversation
tawebbcn
reviewed
Feb 5, 2019
| @@ -1,7 +1,106 @@ | ||
| // Names and Input | ||
| let hacker1 = "Manolo"; |
Contributor
There was a problem hiding this comment.
Como regla general: Uitlizar siempre const hasta que el código de error por intentar reasignar el valor.
Pero buena estructura, declarando la mayoría de las variables en la parte superior.
| } else{ | ||
| if (i === lengthName-1){ | ||
| console.log(finalMessage); | ||
| }else{ |
Contributor
There was a problem hiding this comment.
Al último else parece que nunca entrará, quizás lo reorganizaría. Como elsesolo tendría que haber uno.
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@xavivax1