Paris - Jules & Jules#294
Closed
julesbadin wants to merge 2 commits intoironhack-labs:masterironhack-labs/lab-javascript-basic-algorithms:masterfrom
julesbadin:masterjulesbadin/lab-javascript-basic-algorithms:masterCopy head branch name to clipboard
Closed
Paris - Jules & Jules#294julesbadin wants to merge 2 commits intoironhack-labs:masterironhack-labs/lab-javascript-basic-algorithms:masterfrom julesbadin:masterjulesbadin/lab-javascript-basic-algorithms:masterCopy head branch name to clipboard
julesbadin wants to merge 2 commits intoironhack-labs:masterironhack-labs/lab-javascript-basic-algorithms:masterfrom
julesbadin:masterjulesbadin/lab-javascript-basic-algorithms:masterCopy head branch name to clipboard
Conversation
ta-web-paris
reviewed
Jan 8, 2019
| //Names and Input | ||
|
|
||
| var hacker1 = "Jules"; | ||
| var hacker2 = promt("What's your name ?"); |
There was a problem hiding this comment.
be careful- you mis-spelt prompt here
ta-web-paris
reviewed
Jan 8, 2019
|
|
||
|
|
||
| var words = latin.split(' '); | ||
|
|
There was a problem hiding this comment.
You didn't need to plus one here. But I really like how your way of counting the number of words
ta-web-paris
reviewed
Jan 8, 2019
| console.log(nameReverse); | ||
|
|
||
|
|
||
| if (hacker1[0] < hacker2[0]) { |
There was a problem hiding this comment.
for this to work properly, you need to make it case insensitive. this is because you're really comparing the character codes which is different for uppercase and lowercase letters
|
Good job!! What you've done is good, and it's cool how you used a regex - they can get super complicated 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.