Change NVE multicast groups to accept CIDR format#198
Open
nikatza wants to merge 1 commit intomainironcore-dev/network-operator:mainfrom
251-nve-multicast-networkironcore-dev/network-operator:251-nve-multicast-networkCopy head branch name to clipboard
Open
Change NVE multicast groups to accept CIDR format#198nikatza wants to merge 1 commit intomainironcore-dev/network-operator:mainfrom 251-nve-multicast-networkironcore-dev/network-operator:251-nve-multicast-networkCopy head branch name to clipboard
nikatza wants to merge 1 commit intomainironcore-dev/network-operator:mainfrom
251-nve-multicast-networkironcore-dev/network-operator:251-nve-multicast-networkCopy head branch name to clipboard
Conversation
4822cbb to
af72fa7
Compare
50ce14b to
5780eca
Compare
5780eca to
4039a70
Compare
Accept multicast network prefixes (e.g., 239.1.0.0/16) instead of host addresses. The webhook validates no host bits are set, and the provider extracts the base IP before sending to the device.
4039a70 to
c132ec7
Compare
ddb1262 to
c132ec7
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
felix-kaestner
approved these changes
Mar 3, 2026
Contributor
felix-kaestner
left a comment
There was a problem hiding this comment.
@nikatza Can you please rebase and regenerate the helm chart with make charts to make the adjustments also reflected there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accept multicast network prefixes (e.g., 239.1.0.0/16) instead of host addresses. The webhook validates no host bits are set, and the provider extracts the base IP before sending to the device.