make BlockingKernelClient the default Client #3222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default Client class returned by `KernelManager.client()` should be BlockingKernelClient, because the base KernelClient is incomplete. Ultimately, the base KernelClient will probably become a blocking client, and the Blocking subclass will go away.
Member
|
The kernel client used by the notebook is still the zmq based event loop one right? |
Member
Author
|
Yes, the only effect this has is making the base KernelManager.client method usable, which it is not currently in master, since the base KernelClient is an incomplete base class. |
ellisonbg
added a commit
that referenced
this pull request
Apr 27, 2013
make BlockingKernelClient the default Client
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
make BlockingKernelClient the default Client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Client class returned by
KernelManager.client()should be BlockingKernelClient, because the base KernelClient is incomplete.Ultimately, the base KernelClient will probably become a blocking client, and the Blocking subclass will go away.