Fix re pattern pretty print#14558
Closed
wimglenn wants to merge 1 commit intoipython:mainipython/ipython:mainfrom
Closed
Fix re pattern pretty print#14558wimglenn wants to merge 1 commit intoipython:mainipython/ipython:mainfrom
wimglenn wants to merge 1 commit intoipython:mainipython/ipython:mainfrom
Conversation
wimglenn
added a commit
to wimglenn/ipython
that referenced
this pull request
Oct 24, 2024
Alternative to ipython#14558
Member
|
closing as I merged your #14559 alternative. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re.TEMPLATEis gone in Python 3.13 resulting in a crash in the pattern pretty printerReproducer:
Click me to see the traceback!
Apparently it was "undocumented and never working" (#32300). That was reverted and then usage deprecated immediately in #93161.
Status of existing
re.TEMPLATEattribute in currently supported Python versions for IPython:Since 3.11, using it in the first place causes warnings:
#14559 offers an alternative approach, but it will change the pretty-print result for 3.10-3.12, I'm not sure if that would be considered a backwards-compatibility breaking change.