fix(ipld): update ipld deps, only slurp LargeBytesNode when matching#433
Merged
rvagg merged 1 commit intomainipfs/go-graphsync:mainfrom Aug 29, 2023
rvagg/ipld-and-traversal-updatesipfs/go-graphsync:rvagg/ipld-and-traversal-updatesCopy head branch name to clipboard
Merged
fix(ipld): update ipld deps, only slurp LargeBytesNode when matching#433rvagg merged 1 commit intomainipfs/go-graphsync:mainfrom rvagg/ipld-and-traversal-updatesipfs/go-graphsync:rvagg/ipld-and-traversal-updatesCopy head branch name to clipboard
rvagg merged 1 commit intomainipfs/go-graphsync:mainfrom
rvagg/ipld-and-traversal-updatesipfs/go-graphsync:rvagg/ipld-and-traversal-updatesCopy head branch name to clipboard
Conversation
64b1abc to
dccb6c2
Compare
dccb6c2 to
3e57fa9
Compare
willscott
approved these changes
Aug 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically this targets the new bytes range selector adjustments/fixes in go-ipld-prime. And, for trustless gateway traversals we're using matchers to identify exactly what we want to load, and for byte ranges we match a node that only reads bytes in the blocks of the range we care about.
io.Copy(io.Discard, r)on non-matches is going to encounter the parent node of a file we're exploring to.