feat: MaxLinks for requests#420
Merged
hannahhoward merged 3 commits intomainipfs/go-graphsync:mainfrom Apr 22, 2023
Merged
Conversation
This was referenced Apr 4, 2023
hannahhoward
reviewed
Apr 4, 2023
Collaborator
hannahhoward
left a comment
There was a problem hiding this comment.
Generally LGTM. Is there any reason we shouldn't support this ALSO on the other side (i.e. IncomingRequestHookActions)?
That way the data transfer PR can be for Pushes too.
Member
Author
|
Added support for incoming and outgoing hook configuration of MaxLinks. Also added tests. |
d40f493 to
d23335b
Compare
hannahhoward
pushed a commit
to filecoin-project/lassie
that referenced
this pull request
Apr 22, 2023
hannahhoward
added a commit
to filecoin-project/lassie
that referenced
this pull request
Apr 22, 2023
* feat: use traversal link budget instead of limitstore Ref: ipfs/go-graphsync#420 Ref: filecoin-project/go-data-transfer#374 * chore(deps): update go-data-transfer v2.0.0-rc7 * style(lint): fix fmt --------- Co-authored-by: hannahhoward <hannah@hannahhoward.net>
parkan
pushed a commit
to parkan/sheltie
that referenced
this pull request
Dec 17, 2025
* feat: use traversal link budget instead of limitstore Ref: ipfs/go-graphsync#420 Ref: filecoin-project/go-data-transfer#374 * chore(deps): update go-data-transfer v2.0.0-rc7 * style(lint): fix fmt --------- Co-authored-by: hannahhoward <hannah@hannahhoward.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per-request MaxLinks option.
Only for requests currently. No tests yet. Further discussions in Lassie, follow-up PR there and in go-data-transfer.