uninstall: use execute_process() instead of exec_program() #5285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d86de6 to
2d8a432
Compare
ekyooo
reviewed
Apr 30, 2025
a89c229 to
4f26e42
Compare
|
Rebase to master (commit 5043759) |
|
LGTM |
4f26e42 to
8761399
Compare
|
rebase to master. |
exec_program() is deprecated since 3.28, see: 'cmake --help-policy CMP0153',
and cmake support execute_process() since CMake 2.6.0.
$ sudo make uninstall
....
-- Uninstalling /usr/share/bcc/examples/networking/distributed_bridge/tunnel.py
CMake Warning (dev) at /home/rongtao/Git/bcc/build/CmakeUninstall.cmake:14 (exec_program):
Policy CMP0153 is not set: The exec_program command should not be called.
Run "cmake --help-policy CMP0153" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
Use execute_process() instead.
Call Stack (most recent call first):
/home/rongtao/Git/bcc/build/CmakeUninstall.cmake:28 (UninstallManifest)
This warning is for project developers. Use -Wno-dev to suppress it.
Link: https://cmake.org/cmake/help/v3.12/command/execute_process.html
Signed-off-by: Rong Tao <rongtao@cestc.cn>
8761399 to
884cb29
Compare
|
I downloaded cmake 4.0.2 (https://cmake.org/download/) and can reproduce the warning in the description. With this patch, cmake 4.0.2 and older 3.26.5 do not have any warnings for 'sudo make uninstall'. So the patch LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exec_program() is deprecated since 3.28, see: 'cmake --help-policy CMP0153', and cmake support execute_process() since CMake 2.6.0.