Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix(item-sliding): use the correct gesture direction and side for rtl#18366

Merged
brandyscarney merged 3 commits intomasterionic-team/ionic-framework:masterfrom
fix-item-sliding-rtlionic-team/ionic-framework:fix-item-sliding-rtlCopy head branch name to clipboard
May 23, 2019
Merged

fix(item-sliding): use the correct gesture direction and side for rtl#18366
brandyscarney merged 3 commits intomasterionic-team/ionic-framework:masterfrom
fix-item-sliding-rtlionic-team/ionic-framework:fix-item-sliding-rtlCopy head branch name to clipboard

Conversation

@brandyscarney
Copy link
Member

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The item sliding gesture in RTL was trying to open the opposite side, and the open method was not switching sides based on RTL.

Issue Number: references #17012

What is the new behavior?

  • The open method now checks for RTL and switches the side to open
  • The gesture will drag open the correct side for RTL
  • An e2e test for RTL with the gesture has been added

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label May 23, 2019
@brandyscarney brandyscarney merged commit 4545100 into master May 23, 2019
@brandyscarney brandyscarney deleted the fix-item-sliding-rtl branch May 23, 2019 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.