fix(item-sliding): use the correct gesture direction and side for rtl#18366
Merged
brandyscarney merged 3 commits intomasterionic-team/ionic-framework:masterfrom May 23, 2019
fix-item-sliding-rtlionic-team/ionic-framework:fix-item-sliding-rtlCopy head branch name to clipboard
Merged
fix(item-sliding): use the correct gesture direction and side for rtl#18366brandyscarney merged 3 commits intomasterionic-team/ionic-framework:masterfrom fix-item-sliding-rtlionic-team/ionic-framework:fix-item-sliding-rtlCopy head branch name to clipboard
brandyscarney merged 3 commits intomasterionic-team/ionic-framework:masterfrom
fix-item-sliding-rtlionic-team/ionic-framework:fix-item-sliding-rtlCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The item sliding gesture in RTL was trying to open the opposite side, and the open method was not switching sides based on RTL.
Issue Number: references #17012
What is the new behavior?
Does this introduce a breaking change?
Other information