fix(item-sliding): no longer closes all open items when deleting and item#17579
Merged
liamdebeasi merged 6 commits intomasterionic-team/ionic-framework:masterfrom Feb 28, 2019
fix-item-sliding-openionic-team/ionic-framework:fix-item-sliding-openCopy head branch name to clipboard
Merged
fix(item-sliding): no longer closes all open items when deleting and item#17579liamdebeasi merged 6 commits intomasterionic-team/ionic-framework:masterfrom fix-item-sliding-openionic-team/ionic-framework:fix-item-sliding-openCopy head branch name to clipboard
liamdebeasi merged 6 commits intomasterionic-team/ionic-framework:masterfrom
fix-item-sliding-openionic-team/ionic-framework:fix-item-sliding-openCopy head branch name to clipboard
Conversation
brandyscarney
approved these changes
Feb 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This PR fixes a corner case that was missed in #17492. The fix closed all open items, since that reset
; openSlidingItemhowever, it assumed that the open item was always going to be the item that was deleted, which is not necessarily correct. This PR now only resets theopenSlidingItemvariable if it is the item that is being deleted.Changes proposed in this pull request:
closeOpenedcall whencomponentDidUnloadis firedopenSlidingItemequals the element that was just removed. If it is, setopenSlidingItem = undefinedIonic Version:
Fixes: #17575