fix(progress-bar): RTL (from PR 17157)#17382
Closed
abennouna wants to merge 34 commits intoionic-team:masterionic-team/ionic-framework:masterfrom
abennouna:fix-progress-bar-rtlabennouna/ionic:fix-progress-bar-rtlCopy head branch name to clipboard
Closed
fix(progress-bar): RTL (from PR 17157)#17382abennouna wants to merge 34 commits intoionic-team:masterionic-team/ionic-framework:masterfrom abennouna:fix-progress-bar-rtlabennouna/ionic:fix-progress-bar-rtlCopy head branch name to clipboard
abennouna wants to merge 34 commits intoionic-team:masterionic-team/ionic-framework:masterfrom
abennouna:fix-progress-bar-rtlabennouna/ionic:fix-progress-bar-rtlCopy head branch name to clipboard
Conversation
chore(): update to latest master
Merge pull request #2 from ionic-team/master
pull updates
Merge Master
Pull master
pull from `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
pull `master`
liamdebeasi
suggested changes
Feb 5, 2019
Contributor
There was a problem hiding this comment.
We have a class .progress-bar-reversed that takes care of reversing animations, so we shouldn't need all this extra CSS.
I discussed with @manucorporat regarding the cleanest way to do this. We determined that there should be a change to this line here: https://github.com/ionic-team/ionic/blob/master/core/src/components/progress-bar/progress-bar.tsx#L67
You would want to change that line to 'progress-bar-reversed': document.dir === 'rtl' ? !this.reversed : this.reversed;. That would allow the progress-bar-reversed class to do the heavy lifting in terms of reversing animations.
Contributor
Author
|
Closed in favor of #17464 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes proposed in this pull request:
Ionic Version:
Fixes: #