Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix(icon): update to latest ionicons and add rtl test#17196

Merged
brandyscarney merged 13 commits intomasterionic-team/ionic-framework:masterfrom
fix-icon-rtlionic-team/ionic-framework:fix-icon-rtlCopy head branch name to clipboard
Jan 22, 2019
Merged

fix(icon): update to latest ionicons and add rtl test#17196
brandyscarney merged 13 commits intomasterionic-team/ionic-framework:masterfrom
fix-icon-rtlionic-team/ionic-framework:fix-icon-rtlCopy head branch name to clipboard

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jan 21, 2019

  • Updates to ionicons 4.5.2 which adds rtl support
  • Includes e2e test for RTL icons

References #17012

ltr rtl
ltr-md rtl-md
ltr-ios rtl-ios

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Jan 21, 2019
@brandyscarney brandyscarney merged commit d3b6e60 into master Jan 22, 2019
@brandyscarney brandyscarney deleted the fix-icon-rtl branch January 22, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.