fix(popover): position properly in RTL / MD modes#16745
Merged
adamdbradley merged 7 commits intoionic-team:masterionic-team/ionic-framework:masterfrom Jan 9, 2019
Merged
fix(popover): position properly in RTL / MD modes#16745adamdbradley merged 7 commits intoionic-team:masterionic-team/ionic-framework:masterfrom
adamdbradley merged 7 commits intoionic-team:masterionic-team/ionic-framework:masterfrom
Conversation
chore(): update to latest master
TODO: animation should also be updated for RTL mode
|
merge please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
In MD / RTL mode, popovers are not positioned properly.
Changes proposed in this pull request:
TODO: update the animation “direction” as well. This should be done by having the
transform-originrelative to the right (start) in RTL.Ionic Version: 4.0.0-beta.18
Fixes: #15662