Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

fix(col): handle RTL offset-*, pull-*, and push-*#16702

Merged
adamdbradley merged 12 commits intoionic-team:masterionic-team/ionic-framework:masterfrom
abennouna:fix-rtl-col-offsetabennouna/ionic:fix-rtl-col-offsetCopy head branch name to clipboard
Jan 9, 2019
Merged

fix(col): handle RTL offset-*, pull-*, and push-*#16702
adamdbradley merged 12 commits intoionic-team:masterionic-team/ionic-framework:masterfrom
abennouna:fix-rtl-col-offsetabennouna/ionic:fix-rtl-col-offsetCopy head branch name to clipboard

Conversation

@abennouna
Copy link
Contributor

Short description of what this resolves:

Currently, when the document is RTL, the offset-, push- and pull-* directives do not render as expected.

Changes proposed in this pull request:

  • position properly the col component according document direction

Ionic Version:
v4.0.0-beta.17

Fixes: #16701

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Dec 12, 2018
@adamdbradley adamdbradley merged commit 6d6472b into ionic-team:master Jan 9, 2019
@abennouna abennouna deleted the fix-rtl-col-offset branch January 9, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.