Looking at the way that GitHub resolves links in a README, they seem to resolve all base paths as if they were a directory.

githubResolve('/some/path', '../other-path') => '/some/other-path'
githubResolve('/some/path/', '../other-path') => '/some/other-path'

Whereas Node's plain url.resolve would handle it like this:

url.resolve('/some/path', '../other-path') => '/other-path'
url.resolve('/some/path/', '../other-path') => '/some/other-path'

So I think we should handle it like GitHub and append a trailing slash during resolution if there isn't one.

resolve(/\/$/.test(basePath) ? basePath : `${basePath}/`, href)

Does that make sense?

@camwiegert I was achieving that with the trailing slash here:

But it looks like that got lost in the merge.

@ltm Oh, I see. I think I'd rather move that into the link renderer so that it will apply to every link instead of just the API pages.

@camwiegert 👍