Part Test refactor #9928
Draft
Part Test refactor #9928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| categoryId?: number; | ||
| }>) { | ||
| const table = useTable('part-test'); | ||
| const user = useUserState(); |
Check notice
Code scanning / SonarCloud
Unused assignments should be removed Low
| }>) { | ||
| const table = useTable('part-test'); | ||
| const user = useUserState(); | ||
| const navigate = useNavigate(); |
Check notice
Code scanning / SonarCloud
Unused assignments should be removed Low
Member
Author
|
Bumping to the next release target, a lot to think about here which I don't have time for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents a major overhaul of the testing framework in preparation for the 1.0.0 release.
Prior to this change, the
PartTestTemplatemodel was linked to a specific part. So if the user wanted to assign the "same" test to another part (say in a different category) then the template had to be duplicated.The major change here is to decouple the
PartTestTemplatemodel from thePartmodel - templates are now generic and can be reused. We then add thePartTestmodel which links a template to either aPartorPartCategoryinstance.Link to Part
If a template is linked to a given part, then test results can be generated for any stock item of that part (or any variants of that part).
Link to Category
If a template is linked to a given category then test results can be generated for any part which lives under that category.
TODO
PartTestmodelPartTestinstances against a partPartinstanceStockIteminstance.