Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

glaubinix
Copy link
Contributor

Why?

Using HttpClient, HttpClientDiscovery, MessageFactoryDiscovery, and UriFactory is deprecated.

How?

Used new Psr17/Psr18 interface instead of the deprecated once and changed the request behaviour.

@bobbybouwmann
Copy link

@dannyfallon Can we get this PR merged? It would really help us reduce the number of warnings we get when using this package.

@tobyokeke
Copy link

@dannyfallon @serenaf @GabrielAnca

Gentle reminder to review this PR. This would greatly reduce the warnings gotten while using this package. 🤞

@jhernandis
Copy link

Please, merge it ASAP. We're blocked. Thanks.

@Eclairemoy Eclairemoy self-requested a review January 18, 2024 11:36
@Eclairemoy Eclairemoy enabled auto-merge (squash) January 18, 2024 11:36
@Eclairemoy Eclairemoy merged commit b7ea190 into intercom:master Jan 18, 2024
@glaubinix glaubinix deleted the psr17-psr18 branch January 18, 2024 11:37
@bobbybouwmann
Copy link

@Eclairemoy @glaubinix Thank you for merging this 🙏

Can we also expect a new official release any time soon? I would not like to point our production code to dev-master in the dependencies.

@dannyfallon
Copy link
Contributor

v4.5.0 was just released

@DonyThePony
Copy link

DonyThePony commented Feb 1, 2024

Thank you for the update.
Since I installed the newest version, I am getting the following error.
Call to undefined method GuzzleHttp\Psr7\Request::then()

$intercom = new \Intercom\IntercomClient($intercomConfig['apiKey']);
$intercom->users->create($propArray);

Am I using it wrong, or is it an Issue?

@pidoubleju
Copy link

Thank you for the update. Since I installed the newest version, I am getting the following error. Call to undefined method GuzzleHttp\Psr7\Request::then()

$intercom = new \Intercom\IntercomClient($intercomConfig['apiKey']);
$intercom->users->create($propArray);

Am I using it wrong, or is it an Issue?

If you are on API Version 1.5 or greater, you should be using the contacts resource instead passing the type user

@DonyThePony
Copy link

Thank you for the update. Since I installed the newest version, I am getting the following error. Call to undefined method GuzzleHttp\Psr7\Request::then()

$intercom = new \Intercom\IntercomClient($intercomConfig['apiKey']);
$intercom->users->create($propArray);

Am I using it wrong, or is it an Issue?

If you are on API Version 1.5 or greater, you should be using the contacts resource instead passing the type user

Thank you for the suggestion, but using contacts it results in the same error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.