Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

emilsundberg
Copy link

Why?

Make it possible to delete a company from Intercom

How?

By making an API request to the company delete endpoint

@emilsundberg emilsundberg mentioned this pull request Mar 3, 2021
src/IntercomCompanies.php Outdated Show resolved Hide resolved
Copy link

@rahulgdsouza rahulgdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can merge once the checks clear.

Copy link
Contributor

@GabrielAnca GabrielAnca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I'd complete @rahulgdsouza's comment and add an item to the readme 😄

@emilsundberg
Copy link
Author

I've pushed the changes to adapt to your coding standards. I always try to minimize temporary var usage ;)

Copy link

@rahulgdsouza rahulgdsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs a rebase as it's out-of-date with master. Once that's done I think it's good to go 🚀

@emilsundberg emilsundberg force-pushed the delete-company branch 3 times, most recently from 9eb9dec to 285c111 Compare June 19, 2021 18:31
@emilsundberg
Copy link
Author

✓ Rebased

@rickintveld
Copy link

This pull request is open for a while now, is it possible to merge this? I would like to implement this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.