fixing broken Contacts update method #311
Conversation
"update" should follow the same pattern as other methods like deleteContact and getContact that require "id" based on the API documentation.
|
I don't have time currently to update tests or README for this...so if someone else would like to take that on...that'd be great...but based on my code that I am currently working with...this fixes the update method (which currently does not work for Contacts in 4.4.0) I really do apologize for breaking the rules regarding Pull Requests... I promise I did read them, but I just don't have time at the moment to update everything as I'm on a deadline -- but I thought this might be useful to someone else. Feel free to close, delete or move into an issue instead. |
|
I've gone ahead and fixed the tests and the README file. |
There was a problem hiding this comment.
Thank you for taking the time for this @kevindeleon 🙇 We totally missed this in the last release. Will be releasing a new version straight away
|
@GabrielAnca -- No problem. Glad to help. Hope everyone on your team is healthy and safe. Thanks for the quick release! |
"update" should follow the same pattern as other methods like deleteContact and getContact that require "id" based on the API documentation. https://developers.intercom.com/intercom-api-reference/reference#update-contact
Why?
Because the update method is currently broken for Contacts.
How?
Adds id as a required param.