Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1ce57a1

Browse filesBrowse files
committed
Return Error on invalid offset instead of panic'ing
1 parent f80c952 commit 1ce57a1
Copy full SHA for 1ce57a1

File tree

Expand file treeCollapse file tree

2 files changed

+4
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+4
-1
lines changed
Open diff view settings
Collapse file

‎src/error.rs‎

Copy file name to clipboardExpand all lines: src/error.rs
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ pub enum Error {
3131
/// Request was less than 1024 bytes
3232
RequestTooShort,
3333

34+
/// Offset within message was not 32-bit aligned
35+
InvalidOffsetAlignment(u32),
36+
3437
/// Otherwise invalid request
3538
InvalidRequest,
3639
}
Collapse file

‎src/message.rs‎

Copy file name to clipboardExpand all lines: src/message.rs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ impl RtMessage {
6767
for _ in 0..num_tags - 1 {
6868
let offset = msg.read_u32::<LittleEndian>()?;
6969
if offset % 4 != 0 {
70-
panic!("Invalid offset {:?} in message {:?}", offset, bytes);
70+
return Err(Error::InvalidOffsetAlignment(offset));
7171
}
7272
offsets.push(offset as usize);
7373
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.