Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

Bug fixes: amend DCO sign-off and pass data structures to the submission routes#48

Merged
vishnoianil merged 3 commits intoinstructlab:maininstructlab/ui:mainfrom
nerdalert:yaml-line-breaksnerdalert/ui:yaml-line-breaksCopy head branch name to clipboard
Jul 10, 2024
Merged

Bug fixes: amend DCO sign-off and pass data structures to the submission routes#48
vishnoianil merged 3 commits intoinstructlab:maininstructlab/ui:mainfrom
nerdalert:yaml-line-breaksnerdalert/ui:yaml-line-breaksCopy head branch name to clipboard

Conversation

@nerdalert
Copy link
Collaborator

@nerdalert nerdalert commented Jul 9, 2024 •
edited
Loading

  • Set the length in yaml.dump to enforce a multiline formatting.
  • Pass interfaces to the submission APIs to clean up the number of arguments sent and reduce bad code, e.g. KnowledgeYamlData and SkillYamlData along with AttributionData.
  • Fix amend submissions to add DCO sign-off.
  • Have the user add an email to their edit submission because a GitHub account does not have to have an associated email to look up. Same with name for DCO.
  • Add the ability for the user to specify the submission file path. Sanitizes the file path to be usable. On edit, the file path is pulled in for editing from the existing PR. If amended, the files are added to the new git tree with the new file path. Example: https://github.com/brents-pet-robot/taxonomy-sub-testing/pull/117/files

Closes #47
Closes #42
Closes #32

Apologies for cramming so many things in this PR but each issue would be a rebase on the same files and with the target date of tomorrow.. ¯\(ツ)/¯

nerdalert added 2 commits July 9, 2024 00:19
@nerdalert
Set the yaml.dump line lengths to 80
9ea1a6f 
Setting the lengths to 80 takes care of line breaking for multiline
via the yaml lib.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert
Bugs: add DCO sign-off to edits and pass data structs to api
005762f 
- Pass KnowledgeYamlData and SkillYamlData instead of params
to the submition server side apis.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert nerdalert marked this pull request as draft July 9, 2024 19:42
@nerdalert
Allow the user to set the filepath of the submissions and edits
02ebea2 
- The user needs to be able to play the qna.yml and attribution
files in the appropriate place in the taxonomy tree as well as
being able to edit the file path.

Signed-off-by: Brent Salisbury <bsalisbu@redhat.com>
@nerdalert nerdalert marked this pull request as ready for review July 10, 2024 03:33
@nerdalert nerdalert requested a review from vishnoianil July 10, 2024 03:36
vishnoianil
vishnoianil approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit 391fd33 into instructlab:main Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vishnoianil vishnoianil vishnoianil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@nerdalert @vishnoianil

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.