This repository was archived by the owner on Feb 11, 2026. It is now read-only.
Issue/#28/description for skill and knowledge#38
Merged
nerdalert merged 3 commits intoinstructlab:maininstructlab/ui:mainfrom Jul 8, 2024
aevo98765:issue/#28/description-for-skill-and-knowledgeaevo98765/ui:issue/#28/description-for-skill-and-knowledgeCopy head branch name to clipboard
Merged
Issue/#28/description for skill and knowledge#38nerdalert merged 3 commits intoinstructlab:maininstructlab/ui:mainfrom aevo98765:issue/#28/description-for-skill-and-knowledgeaevo98765/ui:issue/#28/description-for-skill-and-knowledgeCopy head branch name to clipboard
nerdalert merged 3 commits intoinstructlab:maininstructlab/ui:mainfrom
aevo98765:issue/#28/description-for-skill-and-knowledgeaevo98765/ui:issue/#28/description-for-skill-and-knowledgeCopy head branch name to clipboard
Conversation
d86eea3 to
4d149b8
Compare
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
f1fcbcf to
1fb1356
Compare
Collaborator
|
@aevo98765 Looks awesome, would you mind squashing a couple of the commits for the git log (draft, linting) before we merge it? Ty! |
Signed-off-by: Ash Evans <ash.evans@ibm.com>
1fb1356 to
7dbda5a
Compare
Collaborator
Author
|
How does this look now @nerdalert? |
nerdalert
approved these changes
Jul 8, 2024
Collaborator
nerdalert
left a comment
There was a problem hiding this comment.
@aevo98765 awesome. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to address #28.
Very open to both feedback and making changes.