Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

Argocd deployment#275

Merged
vishnoianil merged 2 commits intoinstructlab:maininstructlab/ui:mainfrom
Gregory-Pereira:argocd-deploymentGregory-Pereira/ui:argocd-deploymentCopy head branch name to clipboard
Oct 28, 2024
Merged

Argocd deployment#275
vishnoianil merged 2 commits intoinstructlab:maininstructlab/ui:mainfrom
Gregory-Pereira:argocd-deploymentGregory-Pereira/ui:argocd-deploymentCopy head branch name to clipboard

Conversation

@Gregory-Pereira
Copy link
Collaborator

@Gregory-Pereira Gregory-Pereira commented Oct 15, 2024 •
edited
Loading

cc @vishnoianil and @nerdalert
Addresses: #235

Goals of this PR:

  • setup basics of argocd deployment
  • create argocd applications for prod, staining, and the sealed secrets operator, which we will eventually move to for secret management
  • manage prod deployment via renovate which will update the deployment manifests with the latest release

@Gregory-Pereira
deploy applications via argocd and setup renovate
fdb130f 
Signed-off-by: greg pereira <grpereir@redhat.com>
@vishnoianil
Copy link
Contributor

vishnoianil commented Oct 22, 2024

@Gregory-Pereira awesome, love it. Is it good to go ?

@Gregory-Pereira
Copy link
Collaborator Author

Gregory-Pereira commented Oct 23, 2024

Not quite, still testing the manifests in the cluster. Should have the base stuff ready by end of week

@vishnoianil
Copy link
Contributor

vishnoianil commented Oct 23, 2024

Not quite, still testing the manifests in the cluster. Should have the base stuff ready by end of week

cool. sounds good.

Just sharing some info, in case it's helpful.

Images from the main branch is pushed with the tag main.
images from the release-1.0 branch is pushed with the tag release-1.0. Once we cut the release based on the release-1.0 branch, it creates a tag (eg v1.0.0-beta.3), and the image for this release is pushed with the tag v1.0.0-beta.3 and also as latest` tag.

Production deployment always pulls the latest tag, which will be generated on every release cut. So the argo-cd pipeline should trigger whenever new release is cut.
QA deployment should pull the images with main tag.

@Gregory-Pereira Gregory-Pereira force-pushed the argocd-deployment branch 14 times, most recently from ae9c6a0 to 187e972 Compare October 28, 2024 23:07
@Gregory-Pereira
moving to sealed secrets
188669c 
Signed-off-by: greg pereira <grpereir@redhat.com>
@Gregory-Pereira Gregory-Pereira marked this pull request as ready for review October 28, 2024 23:13
vishnoianil
vishnoianil approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! awesome work! Thanks @Gregory-Pereira

@vishnoianil vishnoianil merged commit 40f029e into instructlab:main Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vishnoianil vishnoianil vishnoianil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gregory-Pereira @vishnoianil

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.