This repository was archived by the owner on Feb 11, 2026. It is now read-only.
Improve the skill form#145
Merged
nerdalert merged 1 commit intoinstructlab:maininstructlab/ui:mainfrom Sep 4, 2024
Merged
Conversation
nerdalert
approved these changes
Sep 4, 2024
b67f06d to
69a8218
Compare
*.* Skill form is updated for the similar look and feel as knowledge form. *.* Mandatory seed exampels are not allowed to delete, but additional seed exampel added by user can be deleted. *.* Each input field has a validation check now. *.* Edit of skill submission uses the same form as main skill form. *.* Refactored skill form similar to knowledge form. *.* Enforced all the constrained imposed by skill schema. Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
69a8218 to
a35627f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
. Skill form is updated for the similar look and feel as knowledge form.
. Mandatory seed exampels are not allowed to delete, but additional seed exampel added by user can be deleted. . Each input field has a validation check now.
. Edit of skill submission uses the same form as main skill form. . Refactored skill form similar to knowledge form. . Enforced all the constrained imposed by skill schema.
Fixes #117