Improve masthead#123
Improve masthead#123vishnoianil merged 9 commits intoinstructlab:maininstructlab/ui:mainfrom aevo98765:issue/#97/improve-mastheadaevo98765/ui:issue/#97/improve-mastheadCopy head branch name to clipboard
Conversation
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
|
|
|
Code for review. @Misjohns I am not sure if you are running the dev branches to see the updated UI. If not we could arrange for me to call and I could share screen. I have attached some screenshots which I believe address what you were asking for. Very open as usual to feedback on this one! |
vishnoianil
left a comment
There was a problem hiding this comment.
PR looks good, thanks for the awesome work. One comment regarding the github login avatar and username. Once that's done, i think it's good to go.
|
Forget to mention another issue. Clicking on Documentation, opens the document in the same tab. In my opinion, it's good to open the documentation in the new tab. |
Signed-off-by: Ash Evans <ash.evans@ibm.com>
…d by linting Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
Signed-off-by: Ash Evans <ash.evans@ibm.com>
|
@vishnoianil done. |
|
The InstructLab icon looks a bit tight in the masthead. Not sure what your masthead height is but for a 76px height I was using 16px padding around the logo. |
Fixes #97